Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock improvements #2937

Open
johncowen opened this issue Sep 16, 2024 · 0 comments
Open

mock improvements #2937

johncowen opened this issue Sep 16, 2024 · 0 comments
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@johncowen
Copy link
Contributor

Description

Our mocks have pretty much stayed using the hurriedly built mocking framework from when we started re-architecting the application, they also started off with a set of mocks from the old-style application that were probably old.

There are several things we could do to make things easier/improve our mocks, some are more urgent than others, so feel free to make sub issues for the following if its easier.

  • Fill out more new style mocks/entities. There are hardly any mocks for new style policies (for example I think only MeshFaultInjection as a full set of mocks), we should fill out at least a couple more.
  • Would be nice to continue Add a vite based server/middleware for our mocks #2001
  • The fs.ts file that the mocks use should ideally be auto generated from the file system. Its beginning to get a little out of hand manually editing these files.
  • Mocks should live in @/app/kuma/ (in a @/app/kuma/mocks folder or similar)
  • We should 'deprecate' old style policies resources. This might mean just splitting them into separate variables for easy removal at a later date.
  • I think I've mentioned a refactor/cleanup of the code fake-api is probably needed, but this is the least priority. It all works fine, just its one of those "I wish this was better organized" whenever i need to go into the code there.
@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Sep 16, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/cleanup Cleanup/refactor an existing component/code and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Sep 23, 2024
@johncowen johncowen added this to the backlog milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants