Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zone mode #1686

Closed
lahabana opened this issue Oct 30, 2023 · 8 comments · Fixed by #1965
Closed

Support zone mode #1686

lahabana opened this issue Oct 30, 2023 · 8 comments · Fixed by #1965
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@lahabana
Copy link
Contributor

Description

With kumahq/kuma#8190 we'll have the GUI in a zone. This means that the GUI should support this. There will likely be NO difference between standalone and zone GUI as zone is the future of Zone.

We may add a page to show KDS connection state of something like this.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Oct 30, 2023
@kleinfreund
Copy link
Contributor

In #1875, I’m adding the zone entry to our translation files so that the UI at least renders in zone mode.

@johncowen
Copy link
Contributor

johncowen commented Dec 6, 2023

GUI follow up taken from the review of #1875 (comment)

Once this is in could we do another PR with the following:

Wherever this is needed can we make it look for common.product.mode first and if not use a defaultMessage of t(http.api.values.${mode})? Let me know if thats problematic for any reason tho.

We should also probably do this for environment aswell (and anything else that is using backend not-quite-http-values)

@kleinfreund
Copy link
Contributor

kleinfreund commented Dec 8, 2023

Edit: The following comment is outdated. Specifically, the Zone in zone mode will actually have a name and so we decided to keep the URL structure used in global mode.


Some more notes:

  • In zone mode, show Zone in the sidebar navigation instead of Zones (global) or Zone Egresses (standalone) that goes to the URL /zone
  • The URL /zone goes to a dedicated Zone detail view that’s different from the regular Zone detail view (name TBD)
    • Question: Does the zone have a name?

      Answer: No

  • Overview data comes from a new endpoint, Config tab comes from /config, Ingresses/Egresses are the same

@lahabana
Copy link
Contributor Author

@lahabana
Copy link
Contributor Author

lahabana commented Jan 8, 2024

There's an extra field called: zone_instance_id that can be present (it's new so it dpends). Probably worth showing

@kleinfreund kleinfreund self-assigned this Jan 8, 2024
@kleinfreund
Copy link
Contributor

kleinfreund commented Jan 8, 2024

Notes:

@kleinfreund
Copy link
Contributor

xref: kumahq/kuma#8767

@kleinfreund kleinfreund changed the title make zone same as standalone Support zone mode Jan 8, 2024
@kleinfreund
Copy link
Contributor

We changed our mind on this again and will do the following on the UI side:

  • global mode: nothing changes
  • zone mode + KDS enabled: nothing changes, the GUI will be disabled on the backend side
  • zone mode + KDS disabled: make everything behave like standalone mode behaves currently (essentially, replace mentions of standalone with zone, i.e. deprecate standalone mode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants