Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification incorrectly counts affected files #23

Open
psylum opened this issue Aug 24, 2017 · 0 comments
Open

Notification incorrectly counts affected files #23

psylum opened this issue Aug 24, 2017 · 0 comments

Comments

@psylum
Copy link

psylum commented Aug 24, 2017

I recently experienced a situation where the plugin sent a notification about a build which included 2 commits, of the following format:
Commit 1:

  • foo/bar - edit
  • foo/baz - edit
    Commit 2:
  • foo/bar - edit

The notification claimed that 3 files were changed. When looking above, it's clear that only 2 files were affected.

It appears this is due to the use of a HashSet<AffectedFile> in ActiveNotifier.getChanges, which i'm guessing the implementation for the AffectedFile interface must not hash based on purely the filename alone. This was using a git repository. I believe it's safer to either use the original getAffectedPaths method, or to get the Paths from each AffectedFile so that the set is based correctly on file paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants