-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiles in multiple tilesets #15
Comments
I've added Spitsbergen to eur_tile_list in the branch for the PR: d649299#diff-98286c01862767995827cdbe52f0fa1fb6fc01c4baac5003196249c717ad3943 |
Should we remove the duplicates? |
So these lists are derived from the global scenery packs for XPlane, so those have duplicates in them. I suppose this makes sense as if you install Europe, you may still want to see some of Asia, etc. Is there any harm leaving the duplicates? Also it may be difficult to figure out which would go where if they were to be removed. |
Some of these though are suspicious, like +46-121 as well. Odd, maybe a mistake was made creating the lists. |
Yeah double checking steamdb.info and that's what's in the global scenery. |
Thanks for looking at it. For me it lead to confusion because my changes to tiles where not depicted in the sim (because I had duplicates in a different scenery area). That would make updated tiles in a scenery area potentially not show up for the users (depending on their order of scenery_packs.ini) unless all areas are regenerated and redownloaded by users. It might have potential technical problems (race conditions?), too if the same tile somehow is served from 2 different mount points? Although in theory I believe only the highest priority scenery is queried I've seen sometimes oddities where for example a hand-crafted Ortho4XP tile would not show up on top of an AO scenery (but that might well have been a testing problem on my side). And removing them would save a little space and computing. 18k tiles out of 21k are unique (-10%). An advantage to keep them would be to stay in sync with the official X-Plane scenery areas. It's tedious but I think it would be worth cleaning the tile lists. |
Just tell me and I'll do a recut along the borders that the X-Plane installer shows. |
That's fixed in |
I just noticed (when testing EKVG +62-008) that quite many tiles are in multiple tile sets.
+48-124.dsf
is even in all tile sets.@kubilus1 do you know why that is? I believe you cut it from X-Plane's scenery areas.
The text was updated successfully, but these errors were encountered: