Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uk] Enhance Readability with Markdown Formatting Improvements #47745

Closed
wants to merge 1 commit into from

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Aug 31, 2024

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 31, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2024
Copy link

netlify bot commented Aug 31, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0a728e1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66d38859ff1e5e00082b9b39
😎 Deploy Preview https://deploy-preview-47745--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member Author

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/language uk

@k8s-ci-robot k8s-ci-robot added the language/uk Issues or PRs related to Ukrainian language label Sep 3, 2024
Copy link
Member Author

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxymVlasov
Copy link
Member

I am not sure that just empty lines changes make any sense

Why it was approved at first place /shrug

#47430 (comment)

@MaxymVlasov
Copy link
Member

MaxymVlasov commented Sep 18, 2024

In any case, I can't approve it, but just to show that I'm okay with these changes in case owners would like to merge it

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3fbcd4a56e557100165599b35862652ab6c55d1a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MaxymVlasov
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaxymVlasov MaxymVlasov removed their assignment Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Arhell Arhell closed this Oct 15, 2024
@Arhell Arhell deleted the uk-line branch October 15, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/uk Issues or PRs related to Ukrainian language lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants