Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Readability with Markdown Formatting Improvements To README.md #47430

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

ywh555hhh
Copy link
Contributor

Description

Dear Team,

I've submitted this PR to enhance the readability and cleanliness of our README.md document. I noticed some minor formatting issues that could affect the presentation of our documentation, and I have made the following careful adjustments:

  • MD022/blanks-around-headings: I've added necessary blank lines around all headings to ensure they stand out visually and are more distinct.
  • MD031/blanks-around-fences: Similarly, I ensured that code blocks are surrounded by blank lines, making the code easier to read while maintaining consistency across our documentation.

Why This Is Needed

We all know that a well-formatted document can greatly enhance the efficiency of information delivery. By following the recommendations of markdownlint, we not only enhance the professionalism of our documentation but also improve the experience for everyone who reads it.

Testing Instructions

  • This update mainly involves formatting changes, so no code-level testing is needed.
  • I have manually reviewed all changes to ensure formatting correctness and maintain content accuracy.

Additional Information

  • I decided to disregard the MD013/line-length issues to preserve our content's original form and style. Sometimes, flexibility in rules is necessary to keep our language flowing naturally.

Let's continue to strive for maintaining high standards and usability in our documentation, making it a strong support in our work. Thank you everyone for your efforts and contributions!

Issue

Closes: none

Copy link

linux-foundation-easycla bot commented Aug 11, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested a review from reylejano August 11, 2024 06:34
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 11, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tengqm August 11, 2024 06:34
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ywh555hhh!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 11, 2024
Copy link

netlify bot commented Aug 11, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 88b24ba
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b85b7c9220c600082f6278
😎 Deploy Preview https://deploy-preview-47430--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@utkarsh-singh1
Copy link
Contributor

@utkarsh-singh1
Copy link
Contributor

/language en

It would be beneficial for the readability, but I don't think it would make changes after render.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 11, 2024
@utkarsh-singh1
Copy link
Contributor

But it improves the documentation, Thanks @ywh555hhh

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is unofficial, but LGTM!

FYI: related issue - #47418

@ywh555hhh
Copy link
Contributor Author

/language en

It would be beneficial for the readability, but I don't think it would make changes after render.

This is really something I don't know, thanks for sharing

@ywh555hhh
Copy link
Contributor Author

Will someone please take a look?

@Okabe-Junya
Copy link
Member

@Okabe-Junya
Copy link
Member

/auto-cc
Please take a look this PR :)

@k8s-ci-robot k8s-ci-robot requested a review from sftim August 20, 2024 15:00
@tengqm tengqm added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 25, 2024
@tengqm
Copy link
Contributor

tengqm commented Aug 25, 2024

/kind cleanup
/lgtm
/approve

Referring to our policy on trivial edits, please consider contribute nontrivial commits to the site next time.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 25, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f37cfddea2dd24a5785a31af076dd10419df75a7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7a07040 into kubernetes:main Aug 25, 2024
6 checks passed
@ywh555hhh
Copy link
Contributor Author

/kind cleanup /lgtm /approve

Referring to our policy on trivial edits, please consider contribute nontrivial commits to the site next time.

Thanks for reminding me, I'll take care of it later!

jimangel pushed a commit to jimangel/website that referenced this pull request Oct 30, 2024
use markdownlint to fix README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants