Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary entries with invalid front matter dates #48752

Open
sreeram-venkitesh opened this issue Nov 18, 2024 · 4 comments
Open

Glossary entries with invalid front matter dates #48752

sreeram-venkitesh opened this issue Nov 18, 2024 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sreeram-venkitesh
Copy link
Member

This is a Bug Report

Problem:

Hugo v0.135.0 throws ERROR the "date" front matter field is not a parsable date in a bunch of places (example) when running make serve. A change to the date validation was shipped in the v0.135.0 release which can throw an error when the date in the frontmatter is of a wrong format. I tested this with Hugo v0.134.3 and this error is not thrown.

Proposed Solution:

Remove date from the glossary entries since we don't need the date in the frontmatter for glossary entries. This was discussed here in Slack.

CC: @sftim

@sreeram-venkitesh sreeram-venkitesh added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 18, 2024
@sreeram-venkitesh
Copy link
Member Author

Here's the full error message I got when trying to run make serve with Hugo v0.135.0

❯ make serve
hugo server --buildFuture --environment development
Watching for changes in /Users/sreeram/OSS/kube/kubernetes-website/{archetypes,assets,content,data,layouts,package.json,postcss.config.js,static,themes}
Watching for config changes in /Users/sreeram/OSS/kube/kubernetes-website/hugo.toml, /Users/sreeram/OSS/kube/kubernetes-website/themes/docsy/config.toml, /Users/sreeram/OSS/kube/kubernetes-website/go.mod
Start building sites …
hugo v0.138.0+extended+withdeploy darwin/amd64 BuildDate=2024-11-06T11:22:34Z VendorInfo=brew

ERROR the "published" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/en/blog/_posts/2018-01-00-Reporting-Errors-Using-Kubernetes-Events.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/zh-cn/blog/_posts/2019-12-09-kubernetes-1.17-release-announcement.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/id/docs/reference/glossary/name.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/id/docs/reference/glossary/uid.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/ko/docs/reference/glossary/object.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/container.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/cri.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/deployment.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/docker.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/etcd.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/kube-proxy.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/kubelet.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/label.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/node.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/pod.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/selector.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/service.md
ERROR the "date" front matter field is not a parsable date: see /Users/sreeram/OSS/kube/kubernetes-website/content/vi/docs/reference/glossary/taint.md
WARN  deprecated: resources.ToCSS was deprecated in Hugo v0.128.0 and will be removed in a future release. Use css.Sass instead.
Built in 1411915 ms
Error: error building site: logged 18 error(s)
make: *** [serve] Error 1

The first two errors cannot be fixed by removing the dates, so we can fix those two. This can be taken up in the same issue. I will update the title to reflect this.

@sreeram-venkitesh sreeram-venkitesh changed the title Remove date from the frontmatter for glossary entries Fix date in frontmatter to valid format Nov 18, 2024
@sftim
Copy link
Contributor

sftim commented Nov 18, 2024

/retitle Glossary entries with invalid front matter dates

(The issue describes the problem, not the fix)

@k8s-ci-robot k8s-ci-robot changed the title Fix date in frontmatter to valid format Glossary entries with invalid front matter dates Nov 18, 2024
@sftim
Copy link
Contributor

sftim commented Nov 18, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 18, 2024
@sftim
Copy link
Contributor

sftim commented Nov 18, 2024

I'll file an issue about the blog paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants