From 40cd288187f447f30384fe3f848d951f08e50197 Mon Sep 17 00:00:00 2001 From: kerthcet Date: Wed, 9 Oct 2024 15:23:45 +0800 Subject: [PATCH 1/2] Graduate NodeInclusionPolicyInPodTopologySpread to GA Signed-off-by: kerthcet --- .../README.md | 20 +++++++++---------- .../kep.yaml | 6 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md index b2104ebc3df..7764bed4d9c 100644 --- a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md +++ b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md @@ -134,7 +134,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release* - [x] (R) KEP approvers have approved the KEP status as `implementable` - [x] (R) Design details are appropriately documented - [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors) - - [ ] e2e Tests for all Beta API Operations (endpoints) + - [x] e2e Tests for all Beta API Operations (endpoints) - [ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) - [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free - [x] (R) Graduation criteria is in place @@ -142,8 +142,8 @@ Items marked with (R) are required *prior to targeting to a milestone / release* - [ ] (R) Production readiness review completed - [ ] (R) Production readiness review approved - [x] "Implementation History" section is up-to-date for milestone -- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io] -- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes +- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io] +- [x] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes -- `pkg/api/pod`: `2022-06-17` - `66.7%` -- `pkg/apis/core/validation`: `2022-06-17` - `82.1%` -- `pkg/scheduler`: `2022-06-17` - `75%` -- `pkg/scheduler/framework/plugins/defaultpreemption`: `2022-06-17` - `85.2%` -- `pkg/scheduler/framework/plugins/podtopologyspread`: `2022-06-17` - `86%` +- `pkg/api/pod`: `2024-10-10` - `74.3%` +- `pkg/apis/core/validation`: `2024-10-10` - `84.3%` +- `pkg/scheduler`: `2024-10-10` - `79.9%` +- `pkg/scheduler/framework/plugins/defaultpreemption`: `2024-10-10` - `85.4%` +- `pkg/scheduler/framework/plugins/podtopologyspread`: `2024-10-10` - `87.2%` ##### Integration tests @@ -792,8 +792,7 @@ Describe the metrics themselves and the reasons why they weren't added (e.g., co implementation difficulties, etc.). --> -Yes, we have a plan to improve observability via metrics [here](https://github.com/kubernetes/kubernetes/issues/110643), -but still on the way. +No. ### Dependencies @@ -954,6 +953,7 @@ Major milestones might include: - 2021.01.12: KEP proposed for review, including motivation, proposal, risks, test plan and graduation criteria. - 2022.09.22: Graduate to Beta in v1.26. +- 2024.10.10: Graduate to GA in v1.32. ## Drawbacks diff --git a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml index cda79287c2c..0892cf8aa95 100644 --- a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml +++ b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml @@ -17,18 +17,18 @@ see-also: - "/keps/sig-scheduling/1258-default-pod-topology-spread" # The target maturity stage in the current dev cycle for this KEP. -stage: beta +stage: stable # The most recent milestone for which work toward delivery of this KEP has been # done. This can be the current (upcoming) milestone, if it is being actively # worked on. -latest-milestone: "v1.25" +latest-milestone: "v1.32" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: alpha: "v1.25" beta: "v1.26" - stable: "" + stable: "1.32" # The following PRR answers are required at alpha release # List the feature gate name and the components for which it must be enabled From da92362f28b09e6feb0abcaf2517a4fc6c0da46b Mon Sep 17 00:00:00 2001 From: kerthcet Date: Wed, 9 Oct 2024 15:57:56 +0800 Subject: [PATCH 2/2] Add PRR approver Signed-off-by: kerthcet --- keps/prod-readiness/sig-scheduling/3094.yaml | 2 ++ .../3094-pod-topology-spread-considering-taints/README.md | 6 +++--- .../3094-pod-topology-spread-considering-taints/kep.yaml | 4 ++++ 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/keps/prod-readiness/sig-scheduling/3094.yaml b/keps/prod-readiness/sig-scheduling/3094.yaml index 8aada6db262..a1b42068ff4 100644 --- a/keps/prod-readiness/sig-scheduling/3094.yaml +++ b/keps/prod-readiness/sig-scheduling/3094.yaml @@ -3,3 +3,5 @@ alpha: approver: "@wojtek-t" beta: approver: "@wojtek-t" +stable: + approver: "@wojtek-t" diff --git a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md index 7764bed4d9c..211fc17e0ed 100644 --- a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md +++ b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md @@ -138,8 +138,8 @@ Items marked with (R) are required *prior to targeting to a milestone / release* - [ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) - [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free - [x] (R) Graduation criteria is in place - - [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) -- [ ] (R) Production readiness review completed + - [x] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) +- [x] (R) Production readiness review completed - [ ] (R) Production readiness review approved - [x] "Implementation History" section is up-to-date for milestone - [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io] @@ -566,7 +566,7 @@ feature, can it break the existing applications?). NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`. --> -Yes, we can just disable the feature gate. +No, but once you leave the related fields unset, this feature will not work. ###### What happens if we reenable the feature if it was previously rolled back? The policies are respected again. diff --git a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml index 0892cf8aa95..37ae06083cc 100644 --- a/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml +++ b/keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml @@ -39,3 +39,7 @@ feature-gates: - kube-scheduler disable-supported: false + +metrics: +- plugin_execution_duration_seconds{plugin="PodTopologySpread"} +- schedule_attempts_total{result="error|unschedulable"}