-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate single email per github handle in sigs.yaml #8178
Comments
uhhhh |
... this is a bit messy to add. We have a validation phase but the output is buried and the Really it would be better if we didn't have to duplicate people definitions and refactored them out to be defined once and referred to by github handle within each of the references in groups, but that's a breaking change and I'm hesitant about what may break. You could imagine using the github handle as a unique key (since github already enforces that) to refer to a single shared map of people by name / employer / email / ... |
On the restriction itself, I am very okay with it. It's a must needed thing. |
That's a good idea. I think we should also consider refactoring out the config to avoid duplicating people definitions by design, but I don't know if we have any requirements on the stability of the format. That would eliminate the need for the test, the need for manual fixups, and the need to manually enter repeated information altogether ... |
... why do I feel like we're constantly re-inventing relational databases? |
Let's take it as a separate concern. We might be over-engineering a flat structure to a relational DB. There are not many people with multiple roles around the community. The number most likely is a handful. |
Haven't YAMLs become databases? 😆 just kidding. |
We should be able to validate that we don't wind up with multiple different emails somehow for contributors with entries for multiple SIGs/WGs
follow-up to #8138
The text was updated successfully, but these errors were encountered: