-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport latest VMs pool, HasInstance(), cloud-provider-azure defork, misc inconsistencies, for 1.27 #7218
Conversation
…inconsistencies, for 1.27
/label tide/merge-method-squash |
ee8938b
to
2b8881b
Compare
@comtalyst: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, comtalyst, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
f9d3bf1
into
kubernetes:cluster-autoscaler-release-1.27
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
These differences have effectively disabled cherry-pick automation in these areas. Upcoming changes (e.g., more VMs pool implementation, cloud-provider-azure integration rework, more fixes that need to be done in all versions) will be agonizing experiences, not to mention the past ones.
This PR will amend some of those differences, which is mostly VMs pool and HasInstance() implementations. They cannot be cherry-picked in normal means easily due to conflict with Azure defork operations, which have to resolve these conflicts at some point anyway. In addition, VMs pool and cloud-provider-azure are required to be cherry-picked.
Some of the inconsistencies are that older versions (1.27, 1.28) have went through linter. This PR might undo that and result in a temporary decrement in quality. However, the trade-off we get is consistency, and has been decided to be worth it. Then all branches will go through linter at the same time later on.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Original
HasInstance()
implementation PR: #6956Original cloud-provider-azure defork PR: #6947
The first half of the commits are basically copy-pasting code from 1.29 while trying to keep differences in features (e.g.,
vmTypeAKS
support that is deprecated from 1.29 and beyond, differences in provisioning states handling). Given that 1.29 is already matured, it is reliable enough.The second half of the commits are cherry-pick of cloud-provider-azure defork, with some modifications to support this version (e.g., use cloud-provider-azure v1.27, replacement for nonexistent MaxDeploymentsCount and KubernetesRateLimit for VMAS and AKS pools respectively, alternative function to support workload identity when cloud-provider-azure still don't support it #5390). Verified that this cloud-provider-azure version has support for AADClientCert.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: