Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Kubelet certificate CA bundle as an argument #1256

Open
qdii opened this issue Apr 29, 2023 · 4 comments · May be fixed by #1516
Open

Pass Kubelet certificate CA bundle as an argument #1256

qdii opened this issue Apr 29, 2023 · 4 comments · May be fixed by #1516
Assignees
@csauoss
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@qdii
Copy link

qdii commented Apr 29, 2023

What would you like to be added:

A new argument --kubelet-certificate-authority-text which allows the CA to be passed as an argument instead of as a path.

Why is this needed:

The current way to feed a CA to metrics-server is to use --kubelet-certificate-authority. This requires the certificate to be present in the metrics-server pod, which isn't easy to do in a persistent way using the Helm chart (maybe we could use extraVolumeMounts and a ad-hoc ConfigMap created for this purpose).

These additional steps makes securing the setup a little bit involved. The ability to simply pass the certificate would ease this.

/kind feature
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 29, 2023
@dgrisonnet
Copy link
Member

/triage accepted
/assign @serathius

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 29, 2023
@serathius serathius removed their assignment Nov 15, 2023
@csauoss
Copy link

csauoss commented Jul 5, 2024

@dgrisonnet I would like to give this a try if it no one has taken it up. Thanks!

@serathius
Copy link
Contributor

/assign @csauoss

@csauoss csauoss linked a pull request Jul 5, 2024 that will close this issue
Open
@csauoss
Copy link

csauoss commented Jul 15, 2024

@serathius @dgrisonnet when you get a chance, can you please review #1516?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csauoss csauoss

Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new flag to allow CA as text argument for kubelet client csauoss/metrics-server
5 participants
@qdii @serathius @k8s-ci-robot @dgrisonnet @csauoss