Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.1 #3950

Closed
26 of 34 tasks
mimowo opened this issue Jan 9, 2025 · 7 comments
Closed
26 of 34 tasks

Release v0.10.1 #3950

mimowo opened this issue Jan 9, 2025 · 7 comments
Assignees

Comments

@mimowo
Copy link
Contributor

mimowo commented Jan 9, 2025

Release Checklist

  • OWNERS must LGTM the release proposal.
    At least two for minor or major releases. At least one for a patch release.
  • Verify that the changelog in this issue and the CHANGELOG folder is up-to-date
  • For major or minor releases (v$MAJ.$MIN.0), create a new release branch.
    • An OWNER creates a vanilla release branch with
      git branch release-$MAJ.$MIN main
    • An OWNER pushes the new release branch with
      git push release-$MAJ.$MIN
  • Update the release branch:
    • Update RELEASE_BRANCH and RELEASE_VERSION in Makefile and run make prepare-release-branch
    • Update the CHANGELOG
    • Submit a pull request with the changes: Prepare release v0.10.1 #4011
  • An OWNER creates a signed tag running
    git tag -s $VERSION
    and inserts the changelog into the tag description.
    To perform this step, you need a PGP key registered on github.
  • An OWNER pushes the tag with
    git push upstream $VERSION
    • Triggers prow to build and publish a staging container image
      us-central1-docker.pkg.dev/k8s-staging-images/kueue/kueue:$VERSION
  • An OWNER prepares a draft release
    • Create the draft release poiting out to the created tag.
    • Write the change log into the draft release.
    • Run
      make artifacts IMAGE_REGISTRY=registry.k8s.io/kueue GIT_TAG=$VERSION
      to generate the artifacts in the artifacts folder.
    • Upload the files in the artifacts folder to the draft release - either
      via UI or gh release --repo kubernetes-sigs/kueue upload <tag> artifacts/*.
  • Submit a PR against k8s.io,
    updating registry.k8s.io/images/k8s-staging-kueue/images.yaml to
    promote the container images
    to production: Promote Kueue v0.10.1 kubernetes/k8s.io#7696
  • Wait for the PR to be merged and verify that the image registry.k8s.io/kueue/kueue:$VERSION is available.
  • Publish the draft release prepared at the GitHub releases page.
    Link: https://github.com/kubernetes-sigs/kueue/releases/tag/v0.10.1
  • Run the openvex action to generate openvex data. The action will add the file to the release artifacts.
  • Update the main branch :
    • Update RELEASE_VERSION in Makefile and run make prepare-release-branch
    • Release notes in the CHANGELOG
    • SECURITY-INSIGHTS.yaml values by running make update-security-insights GIT_TAG=$VERSION
    • Submit a pull request with the changes: Update latest version to v0.10.1 #4018
    • Cherry-pick the pull request onto the website branch
  • Run the SBOM action to generate the SBOM and add it to the release.
  • For major or minor releases, merge the main branch into the website branch to publish the updated documentation.
  • Send an announcement email to [email protected] and [email protected] with the subject [ANNOUNCE] kueue $VERSION is released.
  • For a major or minor release, prepare the repo for the next version:
    • Create an unannotated devel tag in the
      main branch, on the first commit that gets merged after the release
      branch has been created (presumably the README update commit above), and, push the tag:
      DEVEL=v0.$(($MAJ+1)).0-devel; git tag $DEVEL main && git push $DEVEL
      This ensures that the devel builds on the main branch will have a meaningful version number.
    • Create a milestone for the next minor release and update prow to set it automatically for new PRs:
    • Create the presubmits and the periodic jobs for the next patch release:

Changelog

Changes since `v0.10.0`:

## Changes by Kind

### Bug or Regression

- Disable the unnecessary Validating Admission Policy for the visibility server, and drop the associated RBAC permissions to make the server minimal. This also prevents periodic error logging on clusters above Kubernetes 1.29+. (#3946, @varshaprasad96)
- Fix building TAS assignments for workloads with multiple PodSets (eg. JobSet or kubeflow Jobs). The assignment was computed independently for the PodSets which could result in conflicts rendering the pods unschedulable by the kube-scheduler. (#3970, @kerthcet)
- Fix populating the LocalQueue metrics: `kueue_local_queue_resource_usage` and `kueue_local_queue_resource_reservation`. (#3990, @mykysha)
- Fix the bug that prevented scaling StatefulSets which aren't managed by Kueue when the "statefulset" integration is enabled. (#3998, @mbobrovskyi)
- Fix the permission bug which prevented adding the `kueue.x-k8s.io/resource-in-use` finalizer to the Topology objects, resulting in repeatedly logged errors. (#3911, @kerthcet)
- Fixes a bug in 0.10.0 which resulted in the kueue manager configuration not being logged. (#3877, @dgrove-oss)
@mimowo mimowo pinned this issue Jan 9, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Jan 9, 2025

I would like to yet wait to include #3937, and aim for the release next week.

Let me know if there are other important bug fixes we need to include.

/cc @tenzen-y @dgrove-oss @varshaprasad96 @mwielgus @mwysokin @kannon92

@tenzen-y
Copy link
Member

tenzen-y commented Jan 9, 2025

LGTM

@dgrove-oss
Copy link
Contributor

lgtm

@mimowo
Copy link
Contributor Author

mimowo commented Jan 16, 2025

We aim for release tomorrow along with 0.9.3

@mimowo
Copy link
Contributor Author

mimowo commented Jan 20, 2025

The image runs:

> docker run --rm registry.k8s.io/kueue/kueue:v0.10.1 
{"level":"info","ts":"2025-01-20T11:07:07.890029293Z","logger":"setup","caller":"kueue/main.go:423","msg":"Successfully loaded configuration","config":"apiVersion: config.kueue.x-k8s.io/v1beta1\nclientConnection:\n  burst: 30\n  qps: 20\nhealth:\n  healthProbeBindAddress: :8081\nintegrations:\n  frameworks:\n  - batch/job\n  podOptions:\n    namespaceSelector:\n      matchExpressions:\n      - key: kubernetes.io/metadata.name\n        operator: NotIn\n        values:\n        - kube-system\n        - kueue-system\n    podSelector: {}\ninternalCertManagement:\n  enable: true\n  webhookSecretName: kueue-webhook-server-cert\n  webhookServiceName: kueue-webhook-service\nkind: Configuration\nleaderElection:\n  leaderElect: true\n  leaseDuration: 15s\n  renewDeadline: 10s\n  resourceLock: leases\n  resourceName: c1f6bfd2.kueue.x-k8s.io\n  resourceNamespace: \"\"\n  retryPeriod: 2s\nmanageJobsWithoutQueueName: false\nmanagedJobsNamespaceSelector:\n  matchExpressions:\n  - key: kubernetes.io/metadata.name\n    operator: NotIn\n    values:\n    - kube-system\n    - kueue-system\nmetrics:\n  bindAddress: :8080\nmultiKueue:\n  gcInterval: 1m0s\n  origin: multikueue\n  workerLostTimeout: 15m0s\nnamespace: kueue-system\nqueueVisibility:\n  clusterQueues:\n    maxCount: 10\n  updateIntervalSeconds: 5\nwebhook:\n  port: 9443\n"}
{"level":"info","ts":"2025-01-20T11:07:07.890305343Z","logger":"setup","caller":"kueue/main.go:141","msg":"Initializing","gitVersion":"v0.10.1","gitCommit":"404a0cd659b2331b232cf5ddf93a1b67d5cc146c"}

@mimowo
Copy link
Contributor Author

mimowo commented Jan 20, 2025

/close

@k8s-ci-robot
Copy link
Contributor

@mimowo: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants