-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix templating for Upcloud CSI manifest templates #11595
Comments
Hum, I think the problem is rather than the name of the secret is not synced between the manifests : kubespray/roles/kubernetes-apps/csi_driver/upcloud/templates/upcloud-csi-cred-secret.yml.j2 Lines 4 to 6 in f9ebd45
|
/remove-kind feature |
Ah, haha did not see there was a template for a pull secret. Personally I still think it would be nicer to have it templated with Jinja, so that if you configure a pull-secret in your kubespray config, only then it creates the pull-secret |
What would you like to be added
Add jinja templating for imagePullSecret in these upcloud CSI templates:
Similar to how it is done here: https://github.com/kubernetes-sigs/kubespray/blob/v2.26.0/roles/kubernetes-apps/cloud_controller/oci/templates/oci-cloud-provider.yml.j2#L31-L34
Why is this needed
In my cluster on Upcloud, this event/log is getting spammed in cluster about ~6900 times a day in total:
"Unable to retrieve pull secret, the image pull may not succeed."
Which is caused by the
imagePullSecret
being hardcoded for the csi-node and csi-controller pods without the secret being created or required. However, in certain environment it might be needed to override the images and pull them from a private registry, hence, the imagePullSecret should be templated properly instead of being hardcoded.The text was updated successfully, but these errors were encountered: