Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Improve Test Coverage and Alignment for Controller Tests in CronJob Tutorial #4140

Open
camilamacedo86 opened this issue Sep 8, 2024 · 0 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. testing

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

Description:

The current controller tests implemented in the CronJob tutorial (source) provide basic coverage but may benefit from a thorough review. We should ensure that the tests provide sufficient coverage and are fully aligned with Kubebuilder's default scaffolds.

Proposed Changes:

  • Review Current Test Coverage: Analyze the existing tests to identify any gaps in coverage, including untested code paths and edge cases.
  • Enhance Test Implementation: Update and add more tests, where necessary, to cover all critical parts of the controller logic.
  • Alignment with Default Scaffolds: Ensure that the tests follow best practices by comparing them with the default test scaffolds provided by Kubebuilder.
  • Fill Implementation Gaps: Address any potential areas where additional test coverage is needed, ensuring that all edge cases and scenarios are considered.

For example, we might want to enhance it as seen in this experimental approach: PR #4070, which introduces improvements in testing methodologies.

Extra Labels

No response

@camilamacedo86 camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. kind/documentation Categorizes issue or PR as related to documentation. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 8, 2024
@camilamacedo86 camilamacedo86 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. testing labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. testing
Projects
None yet
Development

No branches or pull requests

1 participant