use "github.com/hashicorp/azure" version "<2.0.0"

[nawazkh]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

• The OS DISK URI seemed to have changed with the github.com/hashicorp/azure version >=2.0.0.
  • We expect to see the URI like **/Images/cluster-api-vhds/capi-xyz-osDisk.**
  • Instead we see **/Images/images/packer-osDisk.xyz.vhd
  • Notice the change in the URI
• Moreover, with the plugin github.com/hashicorp/azure version >=2.0.0, we do not see TemplateUriReadOnlySas in the output of Building VHD stage of build_vhd of creating reference images for CAPZ.
• This PR uses the "github.com/hashicorp/azure" version "<2.0.0" in the reference image jobs.

Additional context
Add any other context for the reviewers

[mboersma]

Thanks @nawazkh, this looks good. Could you squash the commits?

[nawazkh]

Is this a flake?

/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/.local/bin/packer validate -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/kubernetes.json"  -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/cni.json"  -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/containerd.json"  -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/wasm-shims.json"  -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/ansible-args.json"  -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/goss-args.json"  -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/common.json"  -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/config/additional_components.json"   -var-file="packer/nutanix/nutanix.json" -var-file="/home/prow/go/src/sigs.k8s.io/image-builder/images/capi/packer/nutanix/ubuntu-2004.json"  packer/nutanix/packer.json
Error: Failed to prepare build: "nutanix"
 4 error(s) occurred:
 * missing nutanix_endpoint
* missing cluster_name
* missing subnet in vm_nics 1
* missing nutanix_password
 make: *** [Makefile:585: validate-nutanix-ubuntu-2004] Error 1
+ EXIT_VALUE=2
+ set +o xtrace

[mboersma]

Is this a flake?

Or somehow a bug crept into main... But I can't reproduce it locally:

% ./images/capi/scripts/ci-packer-validate.sh
<passed>
% make -C images/capi validate-nutanix-all
<passed>

🤷🏻

/retest

[mboersma]

I can reproduce this on Linux, on my Mariner box as well as in the image-builder Docker container:

% docker run registry.k8s.io/scl-image-builder/cluster-node-image-builder-amd64:v0.1.18 validate-nutanix-all 
Starting galaxy collection install process
Nothing to do. All requested collections are already installed. If you want to reinstall them, consider using `--force`.
hack/ensure-packer.sh
packer_1.9.2_linux_amd64.zip: OK
...
file="/home/imagebuilder/packer/nutanix/ubuntu-2004.json"  packer/nutanix/packer.json
Error: Failed to prepare build: "nutanix"

4 error(s) occurred:

* missing nutanix_endpoint
* missing cluster_name
* missing subnet in vm_nics 1
* missing nutanix_password


make: *** [Makefile:585: validate-nutanix-ubuntu-2004] Error 1

I wonder if the nutanix plugin also got updated in some way that breaks things?

[nawazkh]

This was the PR which added nutanix image builder steps #982
It looks like the file https://github.com/kubernetes-sigs/image-builder/blob/main/images/capi/packer/nutanix/nutanix.json is used to populate the variables in https://github.com/kubernetes-sigs/image-builder/blob/main/images/capi/packer/nutanix/packer.json.
I am puzzled that the https://github.com/kubernetes-sigs/image-builder/pull/982 is checked in empty when the steps to build CAPI images for nutanix cloud platform talks about populating it before building the image.

[nawazkh]

Meta question, can we disable checking pull-packer-validate for nutanix targets as a work around? I am not sure if pull-packer-validate was run for other merged PRs.
^ Sorry, that was crude.
This PR #1243 had a successful run of pull-packer-validate.
Is this PR failing on pull-packer-validate because of the version enforcement ? 🤔

[nawazkh]

/test pull-packer-validate

[mboersma]

/retest

[mboersma]

/retest

Grrr GitHub rate limiting. Edit: see #1258.

[mboersma]

/retest

🤞🏻

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• images/capi/packer/azure/OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

See #1259

[nawazkh]

Thank you for creating a follow up issue @mboersma !