-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Private IP of the internal LB of the API Server configurable #5274
make Private IP of the internal LB of the API Server configurable #5274
Conversation
Skipping CI for Draft Pull Request. |
9a4b4be
to
52f19e9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5274 +/- ##
==========================================
+ Coverage 52.82% 52.85% +0.03%
==========================================
Files 270 270
Lines 29085 29121 +36
==========================================
+ Hits 15365 15393 +28
- Misses 12928 12935 +7
- Partials 792 793 +1 ☔ View full report in Codecov by Sentry. |
dac34a8
to
78fdefd
Compare
/assign |
2ca1da5
to
01e4267
Compare
A couple of questions:
Shall I do them in this PR or the uber PR #5248 that is revamping Tilt workflow ? |
- Update cluster.go to add private IP of the ILB - Create private IP to the API Server if not mentioned by the user. Going ahead, every API Server will have one Private IP attached to it. - Add validation logic to the Private IP in the API Server LB Spec.
01e4267
to
2a44ea8
Compare
@nawazkh I think the documentation can be added in the uber PR if it will land prior to the release. Otherwise we'd want the docs to be up to date for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign nojnhuh
LGTM label has been added. Git tree hash: 76b1b171fd6a9e42e3fbcb5cbfcf3e0f7af1d1fd
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
10.0.0.100
(strongly coupled withDefaultVnetCIDR
andDefaultControlPlaneSubnetCIDR
)10.0.0.100
as the VNet CIDR will be opinionated when peering mgmt and workload cluster VNets.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5264
Special notes for your reviewer:
TODOs:
Release note: