Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Azure AD Workload ID docs #4776

Merged
merged 1 commit into from
May 6, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Apr 24, 2024

/kind documentation

What this PR does / why we need it:

Updates the Azure AD Workload ID doc for better formatting and tighter grammar.

Which issue(s) this PR fixes:

Refs #4138

Special notes for your reviewer:

There are probably more substantial changes to be made here to make this an easier document to follow, but I wanted to start by fixing the obvious things, mostly Markdown formatting.

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.48%. Comparing base (d817ab3) to head (ca91421).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4776   +/-   ##
=======================================
  Coverage   62.48%   62.48%           
=======================================
  Files         196      196           
  Lines       16188    16188           
=======================================
  Hits        10115    10115           
  Misses       5333     5333           
  Partials      740      740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/book/src/topics/workload-identity.md Outdated Show resolved Hide resolved
docs/book/src/topics/workload-identity.md Show resolved Hide resolved
docs/book/src/topics/workload-identity.md Outdated Show resolved Hide resolved
@mboersma
Copy link
Contributor Author

/hold

So I don't forget to squash after reviewing.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@mboersma mboersma added this to the v1.15 milestone Apr 25, 2024
@mboersma
Copy link
Contributor Author

/hold cancel

Squashed, awaiting further review.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@willie-yao
Copy link
Contributor

Just had one more comment in case you missed it, otherwise lgtm! #4776 (comment)

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5e1d9e6e6136622812183821f2c46d956a4c655

@mboersma mboersma mentioned this pull request May 1, 2024
4 tasks
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Comment on lines 118 to +119
- Edit the generated `azwi-quickstart.yaml` to make the following changes for
workload identity to the `AzureClusterIdentity` object.
workload identity to the `AzureClusterIdentity` object:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting here that this step won't be necessary after #4765 merges since that changes all the templates to use WorkloadIdentity by default. I don't see this causing any issues though even after that, but would be some easy cleanup.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit e521dec into kubernetes-sigs:main May 6, 2024
18 checks passed
@mboersma mboersma deleted the update-azwi-docs branch May 6, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants