Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨feat(awsmachinepool): custom lifecyclehooks for machinepools #4875

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

✨feat(awsmachinepool): custom lifecyclehooks for machinepools #4875

wants to merge 12 commits into from

Commits on Nov 24, 2024

  1. feat: custom lifecyclehooks for machinepools 

    Taken and rebased from unfinished PR kubernetes-sigs#4875 at commit 2421ec3
    @sebltm
    sebltm committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    6f9b0b5 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @AndiDog @sebltm
    AndiDog authored and sebltm committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    c17c744 View commit details
    Browse the repository at this point in the history

  3. Fix lints

    @AndiDog @sebltm
    AndiDog authored and sebltm committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    4885f2c View commit details
    Browse the repository at this point in the history

  4. Add IAM permissions for lifecycle hooks

    @AndiDog @sebltm
    AndiDog authored and sebltm committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    1075be8 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Create lifecycle hooks together with ASG

    @AndiDog
    AndiDog committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    275b3d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Pass down context

    @AndiDog
    AndiDog committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    171ea12 View commit details
    Browse the repository at this point in the history

  2. Add webhook tests for all lifecycle hook fields and ensure the test c… 

    …overs what we think it does
    @AndiDog
    AndiDog committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    cd21af9 View commit details
    Browse the repository at this point in the history

  3. Undo whitespace-only change (merge mistake)

    @AndiDog
    AndiDog committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8238c4b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Minor test EXPECT() improvement

    @AndiDog
    AndiDog committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5b05e7f View commit details
    Browse the repository at this point in the history

  2. Fix hooks spec logic

    @AndiDog
    AndiDog committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c35bbc3 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Fix lifecycle hook needs-update check for nil fields which get set to… 

    … defaults by AWS
    @AndiDog
    AndiDog committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    66ad8a8 View commit details
    Browse the repository at this point in the history

  2. Always update DefaultResult/HeartbeatTimeout settings if they drifted

    @AndiDog
    AndiDog committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b95757c View commit details
    Browse the repository at this point in the history