Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Support templating extraTags value #329

Open
DevSusu opened this issue Jun 14, 2023 · 7 comments
Open

Question: Support templating extraTags value #329

DevSusu opened this issue Jun 14, 2023 · 7 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@DevSusu
Copy link

DevSusu commented Jun 14, 2023

Hello, I'm considering FSx for storage in EKS cluster.

Been using default EBS driver, which supports templating tags like below
As FSx volume heavier in costs, we need this tags to Seperate Costs by namespace, tenant, ...

https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/tagging.md

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: ebs-sc
provisioner: ebs.csi.aws.com
parameters:
  tagSpecification_1: "pvcnamespace={{ .PVCNamespace }}"
  tagSpecification_2: "pvcname={{ .PVCName }}"
  tagSpecification_3: "pvname={{ .PVName }}"

As per FSx driver docs, it seems only fixed strings can be given, is it correct?
If yes, do you have plans to Support this feature?(templating Tags values, based on PV/PVC resource)

https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/examples/kubernetes/dynamic_provisioning/README.md

extraTags (Optional) - Tags that will be set on the FSx resource created in AWS, in the form of a comma separated list with each tag delimited by an equals sign (example - "Tag1=Value1,Tag2=Value2") . Default is a single tag with CSIVolumeName as the key and the generated volume name as it's value.

/triage support

@k8s-ci-robot
Copy link
Contributor

@DevSusu: The label(s) triage/support cannot be applied, because the repository doesn't have them.

In response to this:

Hello, I'm considering FSx for storage in EKS cluster.

Been using default EBS driver, which supports templating tags like below
As FSx volume heavier in costs, we need this tags to Seperate Costs by namespace, tenant, ...

https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/tagging.md

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
 name: ebs-sc
provisioner: ebs.csi.aws.com
parameters:
 tagSpecification_1: "pvcnamespace={{ .PVCNamespace }}"
 tagSpecification_2: "pvcname={{ .PVCName }}"
 tagSpecification_3: "pvname={{ .PVName }}"

As per FSx driver docs, it seems only fixed strings can be given, is it correct?
If yes, do you have plans to Support this feature?(templating Tags values, based on PV/PVC resource)

https://github.com/kubernetes-sigs/aws-fsx-csi-driver/blob/master/examples/kubernetes/dynamic_provisioning/README.md

extraTags (Optional) - Tags that will be set on the FSx resource created in AWS, in the form of a comma separated list with each tag delimited by an equals sign (example - "Tag1=Value1,Tag2=Value2") . Default is a single tag with CSIVolumeName as the key and the generated volume name as it's value.

/triage support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DevSusu
Copy link
Author

DevSusu commented Jun 14, 2023

Or would it be wiser to create per-tenant StorageClass?

@jacobwolfaws
Copy link
Contributor

jacobwolfaws commented Jun 19, 2023

@DevSusu we're planning on adding this feature to the csi driver. Thanks! Will update this issue as this work progresses

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2024
@jacobwolfaws
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 27, 2024
@vitaly-dt
Copy link

Hello @jacobwolfaws
Is there any estimation as to when this will be supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants