Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the title says "Memory Usage (w/o cache)" should it not show RSS? #999

Closed
dgrieser opened this issue Dec 16, 2024 · 2 comments · Fixed by #1001
Closed

When the title says "Memory Usage (w/o cache)" should it not show RSS? #999

dgrieser opened this issue Dec 16, 2024 · 2 comments · Fixed by #1001
Labels
bug Something isn't working

Comments

@dgrieser
Copy link

Title:

tsPanel.new('Memory Usage (w/o cache)')

Data:

'sum(node_namespace_pod_container:container_memory_working_set_bytes{%(clusterLabel)s="$cluster", node=~"$node", container!=""}) by (pod)' % $._config,

If it is "without cache", should it not be this data:

sum(node_namespace_pod_container:container_memory_rss{%(clusterLabel)s="$cluster", node=~"$node",container!=""}) by (pod)

Either change the title or use a RSS as the metric.

@dgrieser dgrieser changed the title When the title says Memory (w/o cache) should it not show RSS? When the title says "Memory Usage (w/o cache)" should it not show RSS? Dec 16, 2024
@skl skl added the bug Something isn't working label Dec 16, 2024
@skl
Copy link
Collaborator

skl commented Dec 16, 2024

Thanks @dgrieser, let me know what you think to #1001 as a fix for this.

@dgrieser
Copy link
Author

Thanks again for the quick response! Issue #999 and PR #1001 💯

@skl skl closed this as completed in #1001 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants