-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for lists #9
Comments
You are right that lists are not handled. I did not handle it because it is not clear to me how to handle that in the docs. In your example, if here are multiple array elements how does it show up in the doc? |
I think just displaying the index inside square brackets seems to be closest to a standard that I’ve seen - tenants[0], tenants[1] etc - and then leaving it up to users to annotate the different elements accordingly? |
Reread your question:
Would get you: And I think for clarity you’d maybe only ever display the 0th indexed element of any list - comments on eg the second index would be ignored? |
I see that you want to document the structure of the list type values field. If you want to do so, you need to make changes to https://github.com/kubepack/chart-doc-gen/blob/master/walk/associative_sequence.go#L15 file. I am open to prs. |
@robertgates55 my tool helm-docs supports lists in the way you describe already. Why not give it a try? @tamalsaha I wonder if you've seen this project. Seems to do basically the same thing you're attempting here but has been around a couple years so has many more features. |
Thanks for this - really nice.
Got really excited and migrated to this format throughout, and then found that it doesn't look to handle list objects?
Some of the main values blocks in our helm chart look like:
Which you often see documented like:
Is this possible? Is this easily implemented if not?
The text was updated successfully, but these errors were encountered: