Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Migrate the container resource calculation mechanism to k/k library #2280

Open
tenzen-y opened this issue Oct 10, 2024 · 7 comments

Comments

@tenzen-y
Copy link
Member

What you would like to be added?

Currently, we depend on the Kueue container resource request calculation mechanism since the k/k mechanism is not exposed to the third part repositories.

// TODO: Need to address LimitRange and RuntimeClass.
PodRequests: kueuelr.TotalRequests(&spec.podSpec),

But, after the k/k v1.32, we can use the container resource computation library in any repositories: kubernetes/kubernetes#124609

Why is this needed?

Reducing dependencies would be better.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@kannon92
Copy link
Contributor

How would this work with version skew?

Do we migrate to this once 1.32 is the last version supported?

@tenzen-y
Copy link
Member Author

How would this work with version skew?

Do we migrate to this once 1.32 is the last version supported?

I will switch to k/k library once 1.32.0 is released.

@tenzen-y
Copy link
Member Author

How would this work with version skew?
Do we migrate to this once 1.32 is the last version supported?

I will switch to k/k library once 1.32.0 is released.

But, we can use the 1.32.0 after the next kubeflow release since the v1.32 is out of the scope of the next kubeflow release.

@kannon92
Copy link
Contributor

kannon92 commented Oct 12, 2024

sorry I am a bit confused.

Are you saying that if I am running k8s 1.31, kubeflow (once upgraded to v1.32) is not supported in this case?

I can install kubeflow on various versions of kubernetes so I was thinking that if 1.29, 1.30 and 1.31 are still in support, do we need to make sure that Kubeflow can be installed/functional on those?

I guess for v2, we could say that this only supported on k8s 1.32 and on.

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 12, 2024

As you can see here: https://www.kubeflow.org/docs/releases/kubeflow-1.9/
The supported Kubernetes version is defined by the release team, and the version is often a little bit older based on the previous kubeflow releases.

So, I guess that the next supported versions are 1.29 - 1.31.

@tenzen-y
Copy link
Member Author

I guess for v2, we could say that this only supported on k8s 1.32 and on.

I guess that this is so challenging since we need to prepare additional verification infrastructure and go modules and more.
Additionally, if we want to do it, we need to offer the different supported versions to kubeflow vendors (https://www.kubeflow.org/docs/started/installing-kubeflow/#packaged-distributions).

@andreyvelich
Copy link
Member

/remove-label lifecycle/needs-triage
/kind cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants