New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for addition of samples to CONTRIBUTING.md #11264

Open

hbelmiro opened this issue Oct 1, 2024 · 0 comments

Labels

Contributor

hbelmiro commented Oct 1, 2024 •

edited

Loading

Only add samples that showcase Kubeflow Pipelines features. Don't add samples just to showcase a specific algorithm.

Samples should be added to https://github.com/kubeflow/pipelines/tree/f4cdbeb9133a59764657a9ede80e32152d87e9c5/samples/v2.
There should be a test for each new sample, which should be added to https://github.com/kubeflow/pipelines/blob/f4cdbeb9133a59764657a9ede80e32152d87e9c5/samples/v2/sample_test.py

For more information about how the tests are run, see https://github.com/kubeflow/pipelines/blob/f4cdbeb9133a59764657a9ede80e32152d87e9c5/.github/workflows/kfp-samples.yml.

Impacted by this bug? Give it a 👍.

hbelmiro added the kind/bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment