-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ws): add containerSecurityContext
to WorkspaceKind
#20
feat(ws): add containerSecurityContext
to WorkspaceKind
#20
Conversation
…escriptions Signed-off-by: Mathew Wicks <[email protected]>
@jiridanek @ederign @Adembc, for your reference. |
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
@ederign while we wait for @jiridanek to be a member (so he can LGM), can you LGTM this so we can make future PRs based on it? Since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jiridanek thanks /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR brings the CRD spec into line with the latest updates from thesuperzapper/kubeflow-notebooks-v2-design@7aeb44d.
The most important changes are:
spec.podTemplate.containerSecurityContext
to theWorkspaceKind
WorkspacePodMetadata
into*WorkspacePodMetadata