Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): add containerSecurityContext to WorkspaceKind #20

Merged

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Jun 28, 2024

This PR brings the CRD spec into line with the latest updates from thesuperzapper/kubeflow-notebooks-v2-design@7aeb44d.

The most important changes are:

  • Added a spec.podTemplate.containerSecurityContext to the WorkspaceKind
  • Made all optional CRD fields into pointers
    • For example, we made WorkspacePodMetadata into *WorkspacePodMetadata
    • NOTE: this is required to distinguish between unset and empty values, and is recommended by Kubernetes.
  • Updated the descriptions of CRD fields to keep them in line with the sample

@thesuperzapper
Copy link
Member Author

@jiridanek @ederign @Adembc, for your reference.

@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Jun 29, 2024
@thesuperzapper
Copy link
Member Author

@ederign while we wait for @jiridanek to be a member (so he can LGM), can you LGTM this so we can make future PRs based on it?

Since notebooks-v2 is not released its not a big deal if it's only a basic review.

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thesuperzapper
Copy link
Member Author

@jiridanek thanks

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a8de501 into kubeflow:notebooks-v2 Jun 30, 2024
3 checks passed
@thesuperzapper thesuperzapper deleted the update-workspace-crds branch July 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants