Changes requested by code review

Signed-off-by: Eder Ignatowicz <[email protected]>
kubeflow · Jun 28, 2024 · 3e18704 · 3e18704
1 parent 0759562
commit 3e18704
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 19 deletions.
diff --git a/.github/workflows/ui-bff-build.yml b/.github/workflows/ui-bff-build.yml
@@ -1,13 +1,10 @@
 name: UI - BFF - Test and Build
 on:
   push:
-    branches:
-      - 'main'
+    branches: [ "main", "notebooks-v2", "v*-branch" ]
   pull_request:
-    paths-ignore:
-      - 'LICENSE*'
-      - 'DOCKERFILE*'
-      - '**.gitignore'
+    paths: [ "workspaces/backend/**" ]
+    branches: [ "main", "notebooks-v2", "v*-branch" ]
 jobs:
   build:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/ui-frontend-build.yml b/.github/workflows/ui-frontend-build.yml
@@ -1,13 +1,10 @@
 name: UI - Frontend - Test and Build
 on:
   push:
-    branches:
-      - 'main'
+    branches: [ "main", "notebooks-v2", "v*-branch" ]
   pull_request:
-    paths-ignore:
-      - 'LICENSE*'
-      - 'DOCKERFILE*'
-      - '**.gitignore'
+    paths: [ "workspaces/frontend/**" ]
+    branches: [ "main", "notebooks-v2", "v*-branch" ]
 jobs:
   test-and-build:
     runs-on: ubuntu-latest

diff --git a/workspaces/backend/README.md b/workspaces/backend/README.md
@@ -1,5 +1,5 @@
 # Kubeflow Workspaces Backend
-The Kubeflow Workspaces Backend is the _backend for frontend_ (BFF) used by the Kubeflow Workspaces UI as part of [Kubeflow Notebooks 2.0](https://github.com/kubeflow/kubeflow/issues/7156).
+The Kubeflow Workspaces Backend is the _backend for frontend_ (BFF) used by the Kubeflow Workspaces Frontend as part of [Kubeflow Notebooks 2.0](https://github.com/kubeflow/kubeflow/issues/7156).
 
 > ⚠️ __Warning__ ⚠️
 >

diff --git a/workspaces/frontend/README.md b/workspaces/frontend/README.md
@@ -1,5 +1,5 @@
 # Kubeflow Workspaces Frontend
-The Kubeflow Workspaces Frontend is the web application used by the Kubeflow Workspaces as part of [Kubeflow Notebooks 2.0](https://github.com/kubeflow/kubeflow/issues/7156).
+The Kubeflow Workspaces Frontend is the web user interface used to monitor and manage Kubeflow Workspaces as part of [Kubeflow Notebooks 2.0](https://github.com/kubeflow/kubeflow/issues/7156).
 
 > ⚠️ __Warning__ ⚠️
 >

diff --git a/workspaces/frontend/package.json b/workspaces/frontend/package.json
@@ -1,7 +1,7 @@
 {
   "name": "kubeflow-workspaces-frontend",
   "version": "0.0.1",
-  "description": "The Kubeflow Workspaces Frontend is the web application used by the Kubeflow Workspaces as part of Kubeflow Notebooks 2.0",
+  "description": "The Kubeflow Workspaces Frontend is the web user interface used to monitor and manage Kubeflow Workspaces as part of Kubeflow Notebooks 2.0",
   "repository": "https://github.com/kubeflow/notebooks.git",
   "homepage": "https://github.com/kubeflow/notebooks",
   "license": "Apache-2.0",

diff --git a/workspaces/frontend/src/app/routes.tsx b/workspaces/frontend/src/app/routes.tsx
@@ -38,7 +38,7 @@ const routes: AppRouteConfig[] = [
     exact: true,
     label: "Dashboard",
     path: "/",
-    title: "Kubeflow Workspaces | Main Dashboard",
+    title: "Kubeflow Workspaces | Main",
   },
   {
     component: Support,

diff --git a/workspaces/frontend/src/favicon.ico b/workspaces/frontend/src/favicon.ico
diff --git a/workspaces/frontend/src/favicon.png b/workspaces/frontend/src/favicon.png
diff --git a/workspaces/frontend/src/index.html b/workspaces/frontend/src/index.html
@@ -6,7 +6,7 @@
   <title>Kubeflow Workspaces</title>
   <meta content="Kubeflow Workspaces" id="appName" name="application-name">
   <meta content="width=device-width, initial-scale=1.0" name="viewport">
-  <link href="/images/favicon.png" rel="icon" type="image/svg+xml">
+  <link href="/images/favicon.svg" rel="icon" type="image/svg+xml">
   <base href="/">
 </head>
 

diff --git a/workspaces/frontend/tsconfig.json b/workspaces/frontend/tsconfig.json
@@ -4,7 +4,7 @@
     "rootDir": ".",
     "outDir": "dist",
     "module": "esnext",
-    "target": "es5",
+    "target": "ES6",
     "lib": [
       "es6",
       "dom"

diff --git a/workspaces/frontend/webpack.common.js b/workspaces/frontend/webpack.common.js
@@ -119,7 +119,7 @@ module.exports = (env) => {
         silent: true
       }),
       new CopyPlugin({
-        patterns: [{ from: './src/favicon.png', to: 'images' }]
+        patterns: [{ from: './src/favicon.ico', to: 'images' }]
       })
     ],
     resolve: {