Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether the hyperparameter search algorithm will refer to the value of additionalMetricNames #2286

Open
kldancer opened this issue Mar 14, 2024 · 14 comments
Assignees

Comments

@kldancer
Copy link

If not, is the purpose of the additionalMetricNames parameter just for visualization? It will not affect the experimental results?
Please help me answer this question, thank you very much !!!🙏

@andreyvelich
Copy link
Member

That is correct @YKL2436542696

Currently, additionalMetricNames is only used for metrics tracking purposes. So you can get them in the Katib UI or using Katib SDK.
We have an open issue to support multi-objective optimization, but it has not been implemented yet: #1549

@kldancer
Copy link
Author

@andreyvelich Thank you。 Can I understand it this way? The strategies for additionalMetricNames in Spec.Objective.MetricStrategies currently have no practical effect. (This may work when multi-objective optimization is supported in the future)

@kldancer
Copy link
Author

And I noticed that the metrics values output by the "/katib/fetch_hp_job_info/" interface in the katib-ui module are based on spec.Objective.Type and have nothing to do with Spec.Objective.MetricStrategies。
I'm curious why the metric values are not output according to the strategy defined by Spec.Objective.MetricStrategies 🤯

@andreyvelich
Copy link
Member

The strategies for additionalMetricNames in Spec.Objective.MetricStrategies currently have no practical effect.

That's right, we check if Experiment goal is reached based on objective metric name and its metrics strategy: https://github.com/kubeflow/katib/blob/master/pkg/controller.v1beta1/experiment/util/status_util.go#L166

However, we send those metrics to the suggestion service based on the strategies: https://github.com/kubeflow/katib/blob/master/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient.go#L419.
So if user implements custom algorithm service that analyses all Trial metrics that might give some value.

@andreyvelich
Copy link
Member

andreyvelich commented Mar 16, 2024

I'm curious why the metric values are not output according to the strategy defined by Spec.Objective.MetricStrategies

It's a good point, actually UI should just take Trial metrics results from .status.observation and based on strategies should take the appropriate value, not from metrics logs as we do right now: https://github.com/kubeflow/katib/blob/master/pkg/ui/v1beta1/hp.go#L156-L166
Like what we do for Suggestion Service.
Thanks for reporting!

/bug
/area frontend
/good-first-issue

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

I'm curious why the metric values are not output according to the strategy defined by Spec.Objective.MetricStrategies

It's a good point, actually UI should show just take Trial metrics results from .status.observation, not from metrics logs as we do right now: https://github.com/kubeflow/katib/blob/master/pkg/ui/v1beta1/hp.go#L156-L166
Thanks for reporting!

/bug
/area frontend
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added area/frontend good first issue Good for newcomers help wanted Extra attention is needed labels Mar 16, 2024
@andreyvelich
Copy link
Member

/kind bug

@live2awesome
Copy link

live2awesome commented Mar 19, 2024

i am interested in solving this
/assign

@xr-dev-saurabh
Copy link

/assign

@andreyvelich
Copy link
Member

Thank you for your interest @xr-dev-saurabh, as I can see @live2awesome is already working on this issue.
Please feel free to work on other issues that don't have assignee
/assign @live2awesome

@xr-dev-saurabh
Copy link

/unassign

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

@xr-dev-saurabh @live2awesome Do you still want to work on this issue ?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants