Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

[MLMD] Add snapshot testing for LineageView #36

Open
kwasi opened this issue Feb 3, 2020 · 0 comments
Open

[MLMD] Add snapshot testing for LineageView #36

kwasi opened this issue Feb 3, 2020 · 0 comments
Labels
area/metadata Label for metadata related work priority/p0

Comments

@kwasi
Copy link
Contributor

kwasi commented Feb 3, 2020

/area metadata
/priority p0

Background

59cbf3d introduced a regression where resource descriptions were missing. Even though the PR would have required updating snapshots, the missing data would have been very noticeable in the empty descriptions.

We should add tests that handles older data where fields are in ArtifactProperties as well as newer data where fields are in ArtifactCustomProperties.

See https://github.com/kubeflow/metadata/blob/master/frontend/src/pages/ArtifactDetails.test.tsx and its import of testModel for how to construct an instance of the GetArtifactById response with the correct test data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/metadata Label for metadata related work priority/p0
Projects
None yet
Development

No branches or pull requests

2 participants