Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Add importing yaml library on mnist_e2e_on_prem.ipynb (#553) #555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kwonmha
Copy link

@kwonmha kwonmha commented Mar 25, 2021

What this PR does / why we need it:
Added missing import yaml statement.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #553

Special notes for your reviewer:

Let me know if I should add release notes.

Release note:


@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwonmha
To complete the pull request process, please assign jinchihe after the PR has been reviewed.
You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@xauthulei xauthulei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwonmha , you missed the \n, please have try. Thanks

Copy link
Member

@xauthulei xauthulei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here miss the \n

@kwonmha
Copy link
Author

kwonmha commented Mar 26, 2021

Thx @xauthulei .
Added \n.

@xauthulei
Copy link
Member

/lgtm

@jinchihe , it seems the Travis CI have some issue, would you check it please. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name 'yaml' is not defined
3 participants