Feature: Add config setting to disable gzip compression #1627 #1628
Conversation
markdingram
commented
Nov 5, 2024
markdingram
commented
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1628 +/- ##
=======================================
+ Coverage 75.3% 75.5% +0.3%
=======================================
Files 82 82
Lines 7344 7376 +32
=======================================
+ Hits 5528 5567 +39
+ Misses 1816 1809 -7
|
markdingram
force-pushed
the
disable-compression
branch
from
3be2b14
to
06b4b0e
Compare
| .layer(tower_http::decompression::DecompressionLayer::new()) | ||
| .layer( | ||
| tower_http::decompression::DecompressionLayer::new() | ||
| .no_br() |
There was a problem hiding this comment.
intentionally disable anything but GZIP compression -
reading kubernetes/kubernetes#112296 show there isn't like to be any other option in Kube for a while, but these flags could easily be refitted when/if Kube gains alternatives.
There was a problem hiding this comment.
agreed. think this is sensible also.
| @@ -158,7 +158,13 @@ where | |||
| #[cfg(feature = "gzip")] | |||
| let stack = ServiceBuilder::new() | |||
| .layer(stack) | |||
| .layer(tower_http::decompression::DecompressionLayer::new()) | |||
| .layer( | |||
There was a problem hiding this comment.
trying to wrap the whole layer in an "option_layer" block ran head first into a load of compile issues - fortunately the Compression Layer supports enabling/disabling through configuration hence that path was chosen
|
Remaining work on this PR is to add a test to check the Accept-Encoding header when the disabled flag is set |
markdingram
force-pushed
the
disable-compression
branch
3 times, most recently
from
62c7009
to
71598b8
Compare
- rounds out all of the https://kubernetes.io/docs/reference/config-api/kubeconfig.v1/#Cluster options Signed-off-by: Mark Ingram <[email protected]>
markdingram
force-pushed
the
disable-compression
branch
from
71598b8
to
22dfd0a
Compare
| // confirm gzip echoed back with default config | ||
| let config = Config { ..Config::new(uri) }; | ||
| let client = make_generic_builder(HttpConnector::new(), config.clone())?.build(); | ||
| let response = client.request_text(http::Request::default()).await?; | ||
| assert_eq!(&response, "gzip"); | ||
|
|
||
| // now disable and check empty string echoed back | ||
| let config = Config { | ||
| disable_compression: true, | ||
| ..config | ||
| }; | ||
| let client = make_generic_builder(HttpConnector::new(), config)?.build(); | ||
| let response = client.request_text(http::Request::default()).await?; | ||
| assert_eq!(&response, ""); |
