You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
then run just forward-tempo to redirect traffic to that when doing cargo test locally.
Once tempo is being forwarded to we can run just test-telemetry.
We should do one of:
Option 1: Find a way to get valid traceIds without requiring a valid collector
I couldn't figure out how. The mock NoopSamplers returns invalid traces: #45 (comment)
Option 2: Install tempo into the integration test cluster
via something like
- uses: azure/setup-helm@v3
- run: helm install grafana/tempo --wait -f values.yaml
- run: just forward-tempo
- run: just test-telemetry &
then run the integration tests there
Option 3: Run tests manually (current)
Run these tests manually when upgrading opentelemetry/tracing ecosystem. Not ideal, but these tests also doesn't give you the biggest signal, and there's an argument to be made for not having more complicated integration tests setups for a test controller.
Option 4: Find alternate tests
provided we have consistent versions of opentelemetry this should really never break.
maybe we can replace this integration test with some cargo tree based duplicate version check instead.
then on the other hand, it's nice to check that this all works, so probably not.
The text was updated successfully, but these errors were encountered:
Currently we have a single manual test for checking that our trace setup produces valid trace ids (
TraceId != TraceId::INVALID
). See #45To test this we need a valid tracer that (afaikt) needs to talk to something.
The easiest way to currently test this is to setup a tempo instance using something like:
as values for grafana/tempo chart in (tested against 1.0.1 last).
then run
just forward-tempo
to redirect traffic to that when doing cargo test locally.Once tempo is being forwarded to we can run
just test-telemetry
.We should do one of:
Option 1: Find a way to get valid traceIds without requiring a valid collector
I couldn't figure out how. The mock NoopSamplers returns invalid traces: #45 (comment)
Option 2: Install tempo into the integration test cluster
via something like
then run the integration tests there
Option 3: Run tests manually (current)
Run these tests manually when upgrading opentelemetry/tracing ecosystem. Not ideal, but these tests also doesn't give you the biggest signal, and there's an argument to be made for not having more complicated integration tests setups for a test controller.
Option 4: Find alternate tests
provided we have consistent versions of opentelemetry this should really never break.
maybe we can replace this integration test with some
cargo tree
based duplicate version check instead.then on the other hand, it's nice to check that this all works, so probably not.
The text was updated successfully, but these errors were encountered: