Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal has a lot of bogus instances #12

Open
ghost opened this issue May 6, 2014 · 0 comments
Open

Signal has a lot of bogus instances #12

ghost opened this issue May 6, 2014 · 0 comments

Comments

@ghost
Copy link

ghost commented May 6, 2014

The following instances are mostly filled with bottoms:

instance (Rep a, Eq a) => Eq (Signal c a)
instance (Rep a, Enum a) => Enum (Signal i a)
instance (Ord a, Rep a) => Ord (Signal i a)
instance (Rep a, Real a) => Real (Signal i a)

It seems that min and max aren't used, the implementation of min looks odd (primS2 max?). So these instances are all to support Num and Integral, at the cost of deferring type errors to runtime. Are you sure that's worth it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants