Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hermit and hermit-shell programs don't work on GHC 8 #176

Open
roboguy13 opened this issue Sep 20, 2016 · 5 comments
Open

The hermit and hermit-shell programs don't work on GHC 8 #176

roboguy13 opened this issue Sep 20, 2016 · 5 comments

Comments

@roboguy13
Copy link
Member

roboguy13 commented Sep 20, 2016

The plugin itself seems to work okay, but GHC no longer recognizes the flag -fsimple-list-literals (which the hermit and hermit-shell executables pass to ghc). I am going to put in a check to only pass that flag if the GHC version < 8 (for the time being at least).

Is this alright to do? I don't know much about this flag and I can't seem to find much documentation on it. I also can't find any discussion about why it was removed.

@roboguy13
Copy link
Member Author

I went ahead and made this change in cc58c11

@xich
Copy link
Member

xich commented Sep 20, 2016

For some reason the flag was removed in:

ghc/ghc@0db0594

We should probably clamor to have it added back. It prevents list literals from desugaring directly to foldr/build applications. (I've never really understood why they do that in the desugarer instead of via rewrite rules anyway.)

@cartazio
Copy link

cartazio commented Oct 7, 2016

bump :)

@cartazio
Copy link

cartazio commented Oct 7, 2016

is there a branch i can install?

@roboguy13
Copy link
Member Author

roboguy13 commented Oct 7, 2016

@cartazio If you don't need -fsimple-list-literals, then the current master branch should work (cc58c11 should prevent GHC versions >= 8 from using that flag). If you do need it, it will probably be necessary to get the GHC team to add it back into GHC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants