v1.0.0-rc.2

[ktmitton]

This is the second release candidate for this package before the 1.0 release. The minimum requirements were to implement an Sftp server that could be stood up for testing, and allow files to be added or removed as needed.

The focus of this release was to clean up exposed api's before our first release.

Changes since the last release include:

• Replacing KeyValuePair with an Option class
• Separated Container and Network gateway functionality
• Added a boolean to the Run attribute to signify whether the test environment should be torn down after the tests complete
• Implemented our own IAsyncLifetime so we could drop the Xunit dependency from the main library
• Optimized tests to run quicker
• Added ConfigureAwait(false) to awaits to avoid deadlocks

---

This discussion was created from the release v1.0.0-rc.2.

[ktmitton]

At this point, I think we are feature locked for the release, and there aren't any known code changes that are needed. That being said, if there's anything you find that should be fixed before the first release, we are still open to PR's! The main focus before the release now is documentation.

@alsantangelo would you be able review the current README files for any changes you think we should make:

• https://github.com/ktmitton/Mittons.Fixtures/blob/v1.0.0-rc.2/README.md
• https://github.com/ktmitton/Mittons.Fixtures/blob/v1.0.0-rc.2/Mittons.Fixtures/README.md

I'm not sure whether we want to hold up release 1.0.0 for this, but we should also start looking to lock down standards/expectations for the xml comments @Frueber has started implementing in files like this and make that a target for one of the upcoming releases:

https://github.com/ktmitton/Mittons.Fixtures/blob/v1.0.0-rc.2/Mittons.Fixtures/Extensions/OptionExtensions.cs

[ktmitton]

I may make one final feature adjustment to the network alias tab so you can have a container join an external network. This way you can mix this with existing I treating infrastructure.

[ktmitton]

I tried to integrate this into an existing set of tests, and I discovered a couple features we'll need for release 1.0 to be useful:

• Having a way to clear a user's sftp directory will help with test cleanup
• Having a way to get bound ports will be needed to properly set up connections to other containers that don't have their own supported classes yet

Without these, we don't really have something that's usable until a later version.

[ktmitton]

Removing the port binding from a 1.0 mvp. There's no way to implement that properly without implementing later features, so either we implement those now, or we would have to introduce interfaces we don't expect to support. All the necessary functionality is exposed, so if somebody needs it until we implement the feature properly, they can extend the Container class.

Might be worth providing an example.

[ktmitton]

Doing more testing, HealthCheckAttribute needs updated, TimeSpan and int? are not valid types for an attribute.