Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Reader & Writer non-thread-safety #77

Open
Vulcannis opened this issue Apr 19, 2018 · 1 comment
Open

Document Reader & Writer non-thread-safety #77

Vulcannis opened this issue Apr 19, 2018 · 1 comment

Comments

@Vulcannis
Copy link
Contributor

Pretty obvious when you look at BaseImpl, but reader & writer instances are not thread safe when using responseCallback, masqueradeAs and masqueradeType. Actually hit this today while testing, figure it would be nice to at least document it for future users.

The quick fix on my end was to use proxies & ThreadLocal to cache instances.

@ToeBee
Copy link
Member

ToeBee commented Apr 25, 2018

Hmm yes that is definitely a problem users should be made aware of. I think we are avoiding it because we use JMS queues for pushing things to Canvas in parallel and each job creates its own writer object. The readme is already pretty sizable but I'll see if I can fit it in somewhere for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants