-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External tool not found #116
Comments
A side note on this is that when the tool doesn't exist you also get logging warnings:
|
Yeah, the use of I'm kind of tempted to remove it but of course that would break everything. |
If I attempt to get an External Tool from Canvas using:
then if the tool doesn't exist in Canvas I don't get back an empty
Optional
but instead aedu.ksu.canvas.exception.ObjectNotFoundException
is thrown.It seems like either when the
toolId
doesn't exist we should either:Optional
Optional
or is there another reason why we should have both the
Optional
and the exception?The text was updated successfully, but these errors were encountered: