Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner ads interfere with the interface #34

Open
inside83 opened this issue Jan 27, 2021 · 8 comments
Open

Banner ads interfere with the interface #34

inside83 opened this issue Jan 27, 2021 · 8 comments
Assignees
Labels
bug Something isn't working Feature request

Comments

@inside83
Copy link

inside83 commented Jan 27, 2021

Hi
I'm using Google's video ads and if they serve pre-roll, it's all fine.
But if it's a banner, like on the screenshot below, closing an ad (which then minimizes itself) or even if it's up, the interface is unresponsive.
Viewer is unable to click on anything but play/pause, including volume, cast, fullscreen...
Even keyboard shortcuts don't work 🤷‍♂️
There's no error in the console or anything which would point in the right direction.
image
image

@kslimani
Copy link
Owner

kslimani commented Jan 28, 2021

There is a known issue. (issue #3). It should happen mainly on iPhone.

EDIT: please note also this plugin is not fully compatible (yet) with Clappr >= 0.4.x.

@inside83
Copy link
Author

inside83 commented Jan 28, 2021

Thank you for your swift reply.
I can confirm it's happening on Win10/Chrome and on TizenOS's browser.
I'm using clappr/player v0.4.0 since newer versions don't support casting and 0.3.x has issues with respecting playback.hlsjsConfig.maxMaxBufferLength value.

Is it possible to disable non-linear ads altogether, not just on iOS?

@kslimani
Copy link
Owner

The plugin have no option to disable all non-linear ads, thought it is a good idea (and very simple to implement), i will take a look.

@kslimani kslimani self-assigned this Jan 28, 2021
@kslimani kslimani added bug Something isn't working Feature request labels Jan 28, 2021
@kslimani
Copy link
Owner

I released a new version with disableNonLinear plugin configuration option.

@inside83
Copy link
Author

wow, that was super fast 😀👍
is it on jsdelivr too?
https://cdn.jsdelivr.net/npm/clappr-ima-plugin@latest/dist/clappr-ima-plugin.min.js

@kslimani
Copy link
Owner

Yes, it should be available on jsDelivr (ie: cache should be purged and it should be available as latest version).

@inside83
Copy link
Author

inside83 commented Feb 4, 2021

Just a quick follow up:
You said the plugin isn't fully compatible with Clappr >= 0.4.x.
What's the latest Clappr version the plugin is fully compatible and are there any plans on making it compatible to Clappr >= 0.4.x?

@kslimani
Copy link
Owner

kslimani commented Feb 4, 2021

This plugin should work with latest 0.3.x version. (i think it is 0.3.13)

Clappr 0.3.x jsDelivr url : https://cdn.jsdelivr.net/npm/clappr@latest/dist/clappr.min.js

Note: Clappr 0.4.x has many breaking changes. It is one of the reason it is distributed on another npm namespace (@clappr).
Clappr 0.4.x jsDelivr url : https://cdn.jsdelivr.net/npm/@clappr/player@latest/dist/clappr.min.js

I have no exact ETA to making this plugin compatible with 0.4.x but it is definitively in my roadmap.
There are still many changes pending (especially with playbacks internal plugins).
I am currently monitoring these changes and waiting for 0.4 to reach some stability before making this plugin compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Feature request
Projects
None yet
Development

No branches or pull requests

2 participants