Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt same release automation as used by main project (the robot etc) #425

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Nov 21, 2024

Type of change

Select the type of your PR

  • Enhancement / new feature

Description

Update release automation used by the project to match that of the main repo.

Approach: I've literally copied/pasted the files, removing the parts responsible for documentation and update the repo name from kroxylicious -> kroxylicious-junit5-extension.

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@k-wall k-wall changed the title Adopt same release automation at used by main project Adopt same release automation as used by main project (the robot etc) Nov 21, 2024
@k-wall
Copy link
Contributor Author

k-wall commented Nov 21, 2024

@SamBarker @robobario I've given this a spin on my own fork: stage release then drop the release. The the pieces seem to be functioning as expected.

scripts/stage-release.sh Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
RELEASING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@robobario robobario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the little bits are fixed up

Signed-off-by: Keith Wall <[email protected]>
@k-wall k-wall enabled auto-merge (rebase) November 22, 2024 09:29
Copy link

sonarcloud bot commented Nov 22, 2024

@k-wall k-wall merged commit 7f320ce into kroxylicious:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants