New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopicConfig annotation name clash #351

Open

fvaleri opened this issue Jul 3, 2024 · 0 comments

Labels

fvaleri commented Jul 3, 2024

This is a bit ugly:

@Test
public void shouldAlterConfigs(KafkaCluster cluster,
                               @io.kroxylicious.testing.kafka.junit5ext.TopicConfig(name = TopicConfig.RETENTION_MS_CONFIG, value = "604800000") Topic t1,
                               @io.kroxylicious.testing.kafka.junit5ext.TopicConfig(name = TopicConfig.CLEANUP_POLICY_CONFIG, value = "delete") Topic t2) {
...

Maybe we can deprecate this annotation and rename to avoid the name clash with Kafka.

fvaleri added the enhancement label

fvaleri changed the title ~~TopicConfig annotatin name clash~~ TopicConfig annotation name clash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment