Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL escaping in paths is broken. #1

Open
DDR0 opened this issue Nov 22, 2019 · 1 comment
Open

URL escaping in paths is broken. #1

DDR0 opened this issue Nov 22, 2019 · 1 comment
Labels
library issue The libraries we use are old and have known defects. This is one of them manifesting itself. standing We know it's broken. We've looked into it, but we couldn't fix it or we didn't have the time.

Comments

@DDR0
Copy link
Contributor

DDR0 commented Nov 22, 2019

We don't seem to be handling URL-escaping correctly. I got different results trying to access the subscribe URL without a password.

wget http://192.168.1.101/v0/subscribe → 401 Unauthorized
wget http://192.168.1.101/v%30/subscribe → 404 Not Found

The two commands should have returned the same thing.

(reported by @oskirby)
@DDR0 DDR0 added library issue The libraries we use are old and have known defects. This is one of them manifesting itself. standing We know it's broken. We've looked into it, but we couldn't fix it or we didn't have the time. labels Nov 22, 2019
@DDR0
Copy link
Contributor Author

DDR0 commented Nov 22, 2019

This seems to work fine in a browser, since the browser automatically canonicalizes the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
library issue The libraries we use are old and have known defects. This is one of them manifesting itself. standing We know it's broken. We've looked into it, but we couldn't fix it or we didn't have the time.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DDR0