Remove Q.fulfill

[domenic]

We don't like it anymore, I think. It should die before 0.9 goes out the door.

[kriskowal]

I’m going to leave it around in the off-chance it saves some-one’s bacon to be able to mark a value with a then method as a non-promise.

[domenic]

Code sample where it helps please, for historical purposes if nothing else?

[kriskowal]

Supposing you were using: https://github.com/polotek/procstreams

A procstream has a then method, but is not a promise.

function getStream() {
    return prepareToGetStream()
    .then(function () {
        return Q.fulfill(procstream("cat README.md"));
    })
}

[domenic]

Huh, for some reason I thought that wouldn't work, but somehow it does. I think this means I need to revise promises-aplus/promises-spec#76 to take into account such "marked-as-non-thenable thenables."

[kriskowal]

At the end of the day, if this is the only valid use-case, naming it Q.notAPromise(value) might steer folks away from misery.

[domenic]

I like that. In which case, I'd say that deferred.fulfill(x) should die, replaced by deferred.resolve(Q.notAPromise(x)).

[kriskowal]

Yeah. Revising the name again: Q.nonPromise(x).

[rkatic]

Can I ask what are the reasons for "heating" deferred.fulfill? Normalli I am for reducing API-s, but this one seams useful with no additional implementational costs..

[domenic]

My reasoning would be that things you do very uncommonly should have slightly awkard APIs that express exactly what you're trying to do. deferred.resolve(Q.notAPromise(x)) is more explicit than deferred.fulfill(x) and emphasizes that what you want to do is almost always deferred.resolve(x), except maybe sometimes you're dealing with non-promisey thenables and in that case you need to use the explicit Q.notAPromise to mark them as such.