Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadow #91

Open
krharsh17 opened this issue May 2, 2020 · 8 comments
Open

Fix shadow #91

krharsh17 opened this issue May 2, 2020 · 8 comments
Assignees
@spacemonkey1101
Labels
bug Something isn't working documentation Improvements or additions to documentation easy gssoc20
Milestone
PHASE-3 GS20

Comments

@krharsh17
Copy link
Owner

Describe the bug
The shadow's controls are completely broken. Either fix their XML attributes and provide proper documentation in the README.md for them or remove the shadows entirely.
@krharsh17 krharsh17 added bug Something isn't working documentation Improvements or additions to documentation easy gssoc20 labels May 2, 2020
@krharsh17 krharsh17 added this to the PHASE-3 GS20 milestone May 2, 2020
@spacemonkey1101
Copy link
Contributor

would like to work on this.

@spacemonkey1101
Copy link
Contributor

Could I change the these files :
Bar.java
BarView.java
BarGroup.java

@sidhuparas
Copy link
Collaborator

@spacemonkey1101 I think you can modify any suitable file.

@sidhuparas
Copy link
Collaborator

@spacemonkey1101 Any update?

@spacemonkey1101
Copy link
Contributor

im actually struggling with it. Maybe im not getting it

@sidhuparas
Copy link
Collaborator

@spacemonkey1101 Are you having issue understanding the problem? Or are you not getting how to solve it or update the documentation? Me and @krharsh17 are here to help you out.

@spacemonkey1101
Copy link
Contributor

yes Im facing an issue...... I tried to modify some files and values to get the bars to the ideal config.....but i failed repeatedly

@krharsh17
Copy link
Owner Author

krharsh17 commented May 20, 2020 •
edited
Loading

@rajkothari634 has worked on the shadow, maybe he can help in removing/fixing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacemonkey1101 spacemonkey1101

Labels
bug Something isn't working documentation Improvements or additions to documentation easy gssoc20
Projects
None yet
Milestone
PHASE-3 GS20
Development

No branches or pull requests
3 participants
@sidhuparas @spacemonkey1101 @krharsh17