Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal 'ready' event does not update the 'open' flag correctly #186

Closed
harawata opened this issue Sep 1, 2016 · 1 comment
Closed

Modal 'ready' event does not update the 'open' flag correctly #186

harawata opened this issue Sep 1, 2016 · 1 comment

Comments

@harawata
Copy link

harawata commented Sep 1, 2016

Please see the demo.

Just like 'complete', scope.$apply() may be needed after updating the flag.

                        var ready = function() {
                          angular.isFunction(scope.ready) && scope.$apply(scope.ready);
                          // Need to keep open boolean in sync.
                          scope.open = true;
+                         scope.$apply();
                          // If tab support is enabled we need to re-init the tabs
@webbiesdk
Copy link
Collaborator

Right you are, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants