Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to post comment via github instead of textbox/oauth? #35

Open
atymic opened this issue Jan 17, 2021 · 4 comments
Open

Link to post comment via github instead of textbox/oauth? #35

atymic opened this issue Jan 17, 2021 · 4 comments

Comments

@atymic
Copy link

atymic commented Jan 17, 2021

I don't like giving permissions to random things. Any chance we can have a flag to just put a link to the issue instead of forcing them to oauth?

Happy to PR :)

@krasimir
Copy link
Owner

Hey,

there is a link to the issue already. For example here https://krasimirtsonev.com/blog/article/transpile-to-esm-with-babel#comments
Screenshot 2021-01-17 at 10 03 08

@krasimir
Copy link
Owner

krasimir commented Jan 17, 2021

Or you can put a paragraph above/below the form saying "Feel free to comment directly on GitHub here".

@atymic
Copy link
Author

atymic commented Jan 17, 2021

I was more thinking of a flag to disable the textbox/field, and replace it with a "Click here to comment via Github"

I'll fork and have a go at some point, but was wondering if it was something you'd accept back into the project 👍

@krasimir
Copy link
Owner

Oh yes definitely. Happy to review a PR for such feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants