Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini browser window was opened in a new tab when the current window has many tabs or full screen mode #459

Open
lucy5533 opened this issue Sep 12, 2024 · 1 comment

Comments

@lucy5533
Copy link

lucy5533 commented Sep 12, 2024

When the current window has multiple tabs open, the Zoid demo app at https://krakenjs.com/zoid/demo/basic/popup/index.htm intermittently opens in a new tab instead of a mini-browser window. Please see the video below for reference. This issue occurs on both latest Chrome and Edge but does not happen when the demo app is loaded in a new browser window.

mb-issue-zoid.mov

This can also be reproduced by making the window full screen mode, and a new tab will be opened instead of new window even passing in the second render parameter as popup

@lucy5533 lucy5533 changed the title Mini browser window was opened in a new tab when the current window has many tabs Mini browser window was opened in a new tab when the current window has many tabs or full screen mode Sep 16, 2024
@lucy5533
Copy link
Author

I checked https://github.com/krakenjs/zoid/blob/main/demo/basic/popup/login.js#L95, it doesn’t specify context as popup based on https://github.com/krakenjs/zoid/blob/main/docs/api/render.md#context-iframe--popup-1 even though it is used as popup example. We used zoid locally in our app which we specify the context as popup, but we saw a new tab is opened when many tabs are opened in the current window or the current window is set as full screen mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant