Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot 'on exception' doesn't work on nemo@^4 #33

Open
ruslK opened this issue Aug 28, 2018 · 2 comments
Open

Screenshot 'on exception' doesn't work on nemo@^4 #33

ruslK opened this issue Aug 28, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ruslK
Copy link

ruslK commented Aug 28, 2018

with config for nemo@4:

"screenshot": {
            "module": "nemo-screenshot",
            "register": true,
            "arguments": [
                "path:report/screenshots", [ "exception"]] }

there is no screenshot on exception.
But screenshot working on click, or nemo.snap().

@grawk
Copy link
Member

grawk commented Sep 17, 2018

nemo.snap() uses internal screenshot code, as opposed to using the nemo-screenshot module. The nemo-screenshot module used ControlFlow/PromiseManager based code to capture screenshots on exception. That method no longer works now that the PromiseManager is deprecated. So this is essentially an enhancement request. Marking as such, as well as "help wanted" for now.

@grawk grawk added enhancement New feature or request help wanted Extra attention is needed labels Sep 17, 2018
@sainianubhav
Copy link
Contributor

@grawk Could you let me know where to start on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants