Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fatal] (createNode) Unimplemented: node operation GRU #54

Open
YadongChen-1016 opened this issue Sep 13, 2024 · 2 comments
Open

[Fatal] (createNode) Unimplemented: node operation GRU #54

YadongChen-1016 opened this issue Sep 13, 2024 · 2 comments
Labels
good first issue Good for newcomers operand missing ONNX operand not yet implemented in onnx2c

Comments

@YadongChen-1016
Copy link

hi,

I‘m trying to convert a denoiser onnx. Is there no support for GRU conversion yet?

@kraiskil
Copy link
Owner

Yup, that is correct.
After implementing (and bugfixing) LSTM, I didn't have the willpower to redo that for GRU. Also, it is really nice to have an actual network to run inference over to verify the implementation - ONNX unit tests don't offer full coverage.

But with GRU and LSTM being so similar, a version of GRU could be done reasonably quickly by starting with a copy of the LSTM implementation.

@kraiskil kraiskil added good first issue Good for newcomers operand missing ONNX operand not yet implemented in onnx2c labels Sep 14, 2024
@YadongChen-1016
Copy link
Author

Thank you for your explanation.
I look forward to seeing you further improve this great project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers operand missing ONNX operand not yet implemented in onnx2c
Projects
None yet
Development

No branches or pull requests

2 participants