Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to specify temp drawer pop out side? #59

Open
ncrmro opened this issue Nov 28, 2017 · 4 comments
Open

Way to specify temp drawer pop out side? #59

ncrmro opened this issue Nov 28, 2017 · 4 comments

Comments

@ncrmro
Copy link
Contributor

ncrmro commented Nov 28, 2017

Can't seem to find any reference to specifying a side for the drawer to pop out of. Wondering if we could get a left/right boolean prop option, open to making pull request.

@kradio3
Copy link
Owner

kradio3 commented Nov 28, 2017

Hi, @ncrmro
Sure, let's do that

@ncrmro
Copy link
Contributor Author

ncrmro commented Nov 30, 2017

What's the best way to work with the src in a development environment, maybe we also need some contribution docs?

@ncrmro
Copy link
Contributor Author

ncrmro commented Nov 30, 2017

Actually I guess looking at
http://material-components-web.appspot.com/select.html
and building out components in existing project and then porting into this one should suffice.

@kradio3
Copy link
Owner

kradio3 commented Nov 30, 2017

@ncrmro i'm working in following way:

  • clone/fork react-mdc-web
  • create app for testing (for example: git clone https://github.com/kradio3/react-mdc-web-showcase)
  • cd react-mdc-web-showcase
  • npm rm --save-dev react-mdc-web
  • npm i --save-dev ../react-mdc-web
  • npm i --save-dev material-components-web
  • npm start
  • cd ../react-mdc-web
  • npm run watch

'watch' will listen for changes in src and rebuild react-mdc-web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants