Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@include broken for nearley >= 2.16.0 #8

Open
cemulate opened this issue Dec 10, 2019 · 1 comment
Open

@include broken for nearley >= 2.16.0 #8

cemulate opened this issue Dec 10, 2019 · 1 comment

Comments

@cemulate
Copy link

cemulate commented Dec 10, 2019

Nearley made an internal change with how they handle CLI arguments internally in this commit before release 2.16.0.

Unfortunately, that change breaks this package. The context for handling @include directives does not get correctly passed to Nearley. The change needed to handle this is as follows, in src/index.js+12:

- var compilation = compile(parser.results[0], {file: this.resourcePath});
+ var compilation = compile(parser.results[0], {args: [this.resourcePath]});

But I'm not sure what would be wisest to do about versioning. Perhaps bump the major version here and say that ^2 only works with nearley<2.16.0? It's unfortunate for sure.

@cemulate cemulate changed the title @include broken for nearley > 2.16.0 @include broken for nearley >= 2.16.0 Dec 10, 2019
@mspoulsen
Copy link

Somebody please fix this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants