Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets separation and RBAC support #26

Open
Mrkazik99 opened this issue Jul 15, 2024 · 2 comments
Open

Secrets separation and RBAC support #26

Mrkazik99 opened this issue Jul 15, 2024 · 2 comments

Comments

@Mrkazik99
Copy link
Collaborator

For now all secrets are being spreaded all over namespace and in final cluster as well. We should avoid having secrets accessible by other pods than we want. That means we need to prepare RBACs and most likely service accounts for each component, and also adjust secrets gathering from values file.

@dsonck92
Copy link
Collaborator

As I guess this is the major overhaul for secrets, I propose the following structure:

concept:
  existingSecret: xyz
  userKey: CONCEPT_USER
  passwordKey: CONCEPT_PASSWORD
  • concept is something like s3, db, search, redis.
  • existingSecret is undefined by default, which causes the helm managed Secret to be generated and substituted instead
  • userKey and passwordKey default to whatever the generated secret creates, and maps these to the right environment variable by using the env.valueFrom.secretKeyRef.

The idea of using secretKeyRef is to give the user maximum amount of freedom supplying their own secrets. We cannot assume they can supply their secrets in our format, maybe it's some kind of dynamically generated secret.

@dsonck92
Copy link
Collaborator

Also, I think secret separation and rbac are two separate features, so I would split these up. Having separated secrets is a very nice to have, and I don't want that to block on RBAC. Once the secret separation is done, for me, I can migrate over to the new helm chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants