Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric] Implement custom login flow for testing Fabric mods #11

Open
kory33 opened this issue Oct 30, 2021 · 1 comment
Open

[Fabric] Implement custom login flow for testing Fabric mods #11

kory33 opened this issue Oct 30, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kory33
Copy link
Owner

kory33 commented Oct 30, 2021

Testing through Forge or Fabric servers should be possible if we additionally implement DoLogin objects for protocols.

To do this, we need to gain a deeper understanding on how Fabric servers / clients handshake in the Login state.
@kory33 kory33 added help wanted Extra attention is needed enhancement New feature or request labels Oct 30, 2021
kory33 added a commit that referenced this issue Oct 30, 2021
@kory33
feat!(client-impl): change order of given values of withCommonHandshake
e3b87cb 
This is useful for dealing with cases like #11
@kory33
Copy link
Owner Author

kory33 commented Nov 7, 2021

We now have an easy way to specify how clients should communicate LoginPluginResponses. It then remains to implement some non-vanilla handshaking logics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kory33